RFR: 8368551: Core dump warning may be confusing [v2]

Paul Hübner phubner at openjdk.org
Mon Nov 24 09:03:20 UTC 2025


On Mon, 24 Nov 2025 01:39:42 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Paul Hübner has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8368551
>>  - Update doc.
>>  - Overhaul some core messages again.
>>  - Better posix coredump messages.
>
> src/hotspot/os/posix/os_posix.cpp line 129:
> 
>> 127:     } else if (core_path[0] == '"') { // redirect to user process
>> 128:       if (check_only) {
>> 129:         buf.print("core dumps are further processed the following: ");
> 
> Suggestion:
> 
>         buf.print("core dumps are further processed by the following: ");
> 
> or, given these processors are often disabled even if stored in the pattern:
> 
>         buf.print("core dumps may be further processed by the following: ");

I think the second suggestion would be more representative, I'll go ahead and add it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28174#discussion_r2555248492


More information about the hotspot-runtime-dev mailing list