RFR: 8371587: Final mapping lost in ProcSmapsParser::parse_next [v2]

Johan Sjölen jsjolen at openjdk.org
Mon Nov 24 15:13:03 UTC 2025


On Mon, 24 Nov 2025 14:29:41 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> A simple fix for off-by-one error in parsing `smaps` -- the final mapping is never recorded as we exits the parsing loop too early.
>> 
>> The spec of `parse_next` is updated to reflects what its caller expects. The newly added gtest fails without this path.
>> 
>> 
>> Test: tier1
>
> Albert Mingkun Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - copyright-header
>  - review
>  - Merge branch 'master' into smap-parser
>  - smap-parser

Thank you, LGTM!

-------------

Marked as reviewed by jsjolen (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/28225#pullrequestreview-3500895873


More information about the hotspot-runtime-dev mailing list