RFR: 8365526: Crash with null Symbol passed to SystemDictionary::resolve_or_null [v5]

[Coleen Phillimore]

On Wed, 26 Nov 2025 06:32:51 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use put_when_absent and add an assert that the message is the same.
>
> src/hotspot/share/classfile/systemDictionary.cpp line 1869:
> 
>> 1867:     if (entry == nullptr) {
>> 1868:       // Only add a new resolution error if one hasn't been found for this constant pool index. In this case,
>> 1869:       // resolution succeeded but there's an error in this nest host.
> 
> Suggestion:
> 
>       // Only add a new entry to the resolution error table if one hasn't been found for this 
>       // constant pool index. In this case resolution succeeded but there's an error in this nest host
>       // that we use the table to record.

I do not believe this is true.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28438#discussion_r2564979562