RFR: 8372625: [Linux] Remove unnecessary logic for supports_fast_thread_cpu_time [v3]

Jonas Norlinder jnorlinder at openjdk.org
Fri Nov 28 08:47:04 UTC 2025


On Fri, 28 Nov 2025 02:37:58 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Jonas Norlinder has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   kstefanj review comments
>
> src/hotspot/share/runtime/cpuTimeCounters.cpp line 123:
> 
>> 121:   // The default code path (fast_thread_cpu_time()) asserts that
>> 122:   // pthread_getcpuclockid() and clock_gettime() must return 0. Thus caller
>> 123:   // must ensure the thread exists and has not terminated.
> 
> I think the part about ensuring the thread exists and has not terminated still applies.

Yes it still applies but I'm not sure that this comment should be in this method. If we want to inform users about this assumption we should add a comment in `os` in my opinion.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28516#discussion_r2570844294


More information about the hotspot-runtime-dev mailing list