RFR: 8372584: [Linux]: Replace reading proc to get thread user CPU time with clock_gettime
Jonas Norlinder
jnorlinder at openjdk.org
Fri Nov 28 13:10:49 UTC 2025
On Fri, 28 Nov 2025 12:13:44 GMT, Francesco Andreuzzi <fandreuzzi at openjdk.org> wrote:
>> Since kernel v2.6.12 the Linux ABI have had support for encoding the clock types in the last three bits. Setting bit to 001 (CPUCLOCK_VIRT) will result in the kernel returning only user time. POSIX compliant implementations of pthread_getcpuclockid for the Linux kernel defaults to construct a clockid that with 010 (CPUCLOCK_SCHED) set, which return system+user time, which is what the POSIX standard mandates, see POSIX.1-2024/IEEE Std 1003.1-2024 §3.90. This patch joins the family of glibc, musl etc. that utilities this bit pattern.
>>
>> This PR also results in improved performance and thus a reduced observer effect, especially for the 100th percentile (max).
>>
>> Before patch:
>>
>> Benchmark Mode Cnt Score Error Units
>> CPUTime.execute sample 7506555 0.008 ± 0.001 ms/op
>> CPUTime.execute:p0.00 sample 0.008 ms/op
>> CPUTime.execute:p0.50 sample 0.008 ms/op
>> CPUTime.execute:p0.90 sample 0.008 ms/op
>> CPUTime.execute:p0.95 sample 0.008 ms/op
>> CPUTime.execute:p0.99 sample 0.012 ms/op
>> CPUTime.execute:p0.999 sample 0.015 ms/op
>> CPUTime.execute:p0.9999 sample 0.021 ms/op
>> CPUTime.execute:p1.00 sample 1.030 ms/op
>>
>>
>> After patch:
>>
>> Benchmark Mode Cnt Score Error Units
>> CPUTime.execute sample 8984189 ≈ 10⁻³ ms/op
>> CPUTime.execute:p0.00 sample ≈ 10⁻³ ms/op
>> CPUTime.execute:p0.50 sample ≈ 10⁻³ ms/op
>> CPUTime.execute:p0.90 sample ≈ 10⁻³ ms/op
>> CPUTime.execute:p0.95 sample ≈ 10⁻³ ms/op
>> CPUTime.execute:p0.99 sample 0.001 ms/op
>> CPUTime.execute:p0.999 sample 0.001 ms/op
>> CPUTime.execute:p0.9999 sample 0.006 ms/op
>> CPUTime.execute:p1.00 sample 0.054 ms/op
>>
>>
>> Testing: `java/lang/management/ThreadMXBean/ThreadUserTime.java` and the added microbenchmark.
>
> src/hotspot/os/linux/os_linux.cpp line 4964:
>
>> 4962: // in the last three bits. Setting bit to 001 (CPUCLOCK_VIRT) will result in the kernel
>> 4963: // returning only user time. POSIX compliant implementations of pthread_getcpuclockid
>> 4964: // for the Linux kernel defaults to construct a clockid that with 010 (CPUCLOCK_SCHED)
>
> Is `that with` intended here? It would make sense to me to have just `with`
Thanks! It should be "with".
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28556#discussion_r2571646138
More information about the hotspot-runtime-dev
mailing list