RFR: 8369037: Identify owning method for MethodData and MethodCounters in AOT map output [v5]

[Mat Carter]

On Thu, 2 Oct 2025 17:16:41 GMT, María Arias de Reyna <duke at openjdk.org> wrote:

>> Part of https://bugs.openjdk.org/browse/JDK-8369037
>> Provides part of fixes needed to resolve https://bugs.openjdk.org/browse/JDK-8363440
>> 
>> The AOT map file lists many objects without any kind of context of what they represent. For example, `MethodCounters` and `MethodData` do not show to what method they belong to. With this patch, now we can at least link the `MethodCounters` and `MethodData` to the `Method` they belong to.
>> 
>> Before:
>> 
>> $ cat aot.map | grep "@@ MethodCounters"
>> [...]
>> 0x0000000801e4c280: @@ MethodCounters    64
>> 
>> ``` bash
>> $ cat aot.map | grep "@@ MethodData"
>> [...]
>> 0x0000000801e44448: @@ MethodData        584
>> 
>> 
>> After:
>> 
>> $ cat aot.map | grep "@@ MethodCounters"
>> [...]
>> 0x0000000801f8b9a8: @@ MethodCounters    64 void jdk.internal.access.SharedSecrets.setJavaLangAccess(jdk.internal.access.JavaLangAccess)
>> 0x0000000801f8be60: @@ MethodCounters    64 void java.lang.Object.notifyAll()
>> 
>> ``` bash
>> $ cat aot.map | grep "@@ MethodData"
>> [...]
>> 0x0000000801f700e0: @@ MethodData        728 int java.lang.module.ModuleDescriptor.hashCode()
>> 0x0000000801f81af0: @@ MethodData        688 java.lang.String java.lang.Class.cannotCastMsg(java.lang.Object)
>
> María Arias de Reyna has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixing style: aligning parameters with '('

Marked as reviewed by macarte (Author).

src/hotspot/share/cds/aotMapLogger.cpp line 400:

> 398: }
> 399: 
> 400: void AOTMapLogger::log_method_counter(MethodCounters* mc, address requested_addr, const char* type_name,

nit: perhaps name this log_method_counters [plural case] for consistency in the code

-------------

PR Review: https://git.openjdk.org/jdk/pull/27603#pullrequestreview-3295737165
PR Review Comment: https://git.openjdk.org/jdk/pull/27603#discussion_r2399602398