RFR: 8369250: Assess and remedy any unsafe usage of the Semaphore used by NonJavaThread::List

[Stefan Karlsson]

On Tue, 7 Oct 2025 10:41:32 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> http://cppreference.com/w/cpp/language/static.html
>>> The declaration inside the class body is not a definition and may declare the member to be of [incomplete type](https://www.cppreference.com/w/cpp/language/incomplete_type.html)
>
> I didn't initially move the definition of the `List` class and it failed to build for me - hence I had to move it.
> 
> What is the concern with defining `List` in the header file???

It added an unnecessary dependency to the header (SingleWriterSynchronizer) and it made the class uglier than it had to. My 2c.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27664#discussion_r2410383501