RFR: 8369250: Assess and remedy any unsafe usage of the Semaphore used by NonJavaThread::List [v2]
David Holmes
dholmes at openjdk.org
Tue Oct 7 21:23:57 UTC 2025
On Tue, 7 Oct 2025 11:59:00 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
>> I didn't initially move the definition of the `List` class and it failed to build for me - hence I had to move it.
>>
>> What is the concern with defining `List` in the header file???
>
> It added an unnecessary dependency to the header (SingleWriterSynchronizer) and it made the class uglier than it had to. My 2c.
Okay - the problem I had was the definition of the `init` function in the hpp file instead of the cpp file. Fixed per @stefank 's code above. Thanks
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27664#discussion_r2411955211
More information about the hotspot-runtime-dev
mailing list