RFR: 8369622: GlobalChunkPoolMutex needs to be recursive
Stefan Karlsson
stefank at openjdk.org
Tue Oct 14 13:50:42 UTC 2025
On Tue, 14 Oct 2025 13:30:28 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> src/hotspot/share/memory/arena.cpp line 250:
>>
>>> 248: static const int cleaning_interval = 5000; // cleaning interval in ms
>>> 249:
>>> 250: public:
>>
>> The style guide doesn't mention this but I thought the unofficial preference was for one character indent so that we don't have lines at the same level as the outermost class definition.
>
> The style guide doesn't mention it because I don't think we have consistent
> usage, and I haven't felt like stirring that pot. (Others are, of course, free
> to do so.) Personally I use no-indent unless the surrounding code uses
> 1sp-indent. And only change an existing 1sp-indent to no-indent if it seems
> out of place compared to surrounding code and I happen to be touching
> something nearby. (switch/case labels are similarly inconsistent in our code.)
FWIW, I've been removing one-space indents for years now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27759#discussion_r2429270384
More information about the hotspot-runtime-dev
mailing list