RFR: 8369734: JvmtiExport::post_class_file_load_hook return value is never used [v3]

David Holmes dholmes at openjdk.org
Wed Oct 15 12:40:00 UTC 2025


On Wed, 15 Oct 2025 09:32:19 GMT, Francesco Andreuzzi <fandreuzzi at openjdk.org> wrote:

>> The return value of `JvmtiExport::post_class_file_load_hook` is never used, so we can remove the related dead code.
>> 
>> Passes tier1 and tier2 (fastdebug).
>
> Francesco Andreuzzi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   don't return

LGTM. Thanks

src/hotspot/share/prims/jvmtiExport.cpp line 985:

> 983:     }
> 984:     if (new_data != nullptr) {
> 985:       // this agent has modified class data.

The comment could stay.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/27777#pullrequestreview-3340151397
PR Review Comment: https://git.openjdk.org/jdk/pull/27777#discussion_r2432392717


More information about the hotspot-runtime-dev mailing list