RFR: 8368781: PerfMemory - make issues more transparent [v5]
David Holmes
dholmes at openjdk.org
Mon Oct 20 03:02:05 UTC 2025
On Fri, 17 Oct 2025 12:50:59 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> Currently issues with perfMemory like problems with the secure tmp subdirectory creation are not very transparent in release JVMs.
>>
>> There exists some warnings traces but they are behind develop flags like Verbose so only available in debug JVMs.
>> We could (in case of issues) store some information and write it later into hsinfo/hserr files ; or make the existing warnings available too in release JVMs.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>
> Adjust log calls
Changes requested by dholmes (Reviewer).
src/hotspot/os/posix/perfMemory_posix.cpp line 76:
> 74: if (!os::commit_memory(mapAddress, size, !ExecMem)) {
> 75: if (log_is_enabled(Debug, perf)) {
> 76: log_debug(perf)("Could not commit PerfData memory");
You don't need the `log_is_enabled` check with a single logging statement as the `log_debug` is a macro that already contains the check.
-------------
PR Review: https://git.openjdk.org/jdk/pull/27602#pullrequestreview-3354912434
PR Review Comment: https://git.openjdk.org/jdk/pull/27602#discussion_r2443716118
More information about the hotspot-runtime-dev
mailing list