RFR: 8368781: PerfMemory - make issues more transparent [v5]

Matthias Baesken mbaesken at openjdk.org
Mon Oct 20 11:13:04 UTC 2025


On Mon, 20 Oct 2025 02:58:43 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adjust log calls
>
> src/hotspot/os/posix/perfMemory_posix.cpp line 76:
> 
>> 74:   if (!os::commit_memory(mapAddress, size, !ExecMem)) {
>> 75:     if (log_is_enabled(Debug, perf)) {
>> 76:       log_debug(perf)("Could not commit PerfData memory");
> 
> You don't need the `log_is_enabled` check with a single logging statement as the `log_debug` is a macro that already contains the check.

That's good, saves us quite a few lines !

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27602#discussion_r2444704430


More information about the hotspot-runtime-dev mailing list