RFR: 8369322: Implement native stack printing for Windows-AArch64 [v2]
Martijn Verburg
karianna at openjdk.org
Mon Oct 20 21:51:05 UTC 2025
On Mon, 20 Oct 2025 20:22:43 GMT, Saint Wesonga <duke at openjdk.org> wrote:
>> src/hotspot/os/windows/os_windows.cpp line 6286:
>>
>>> 6284:
>>> 6285: /*
>>> 6286: * Windows/x64 does not use stack frames the way expected by Java:
>>
>> Should that comment say /x64 if it's for all aarchs?
>
>> Should that comment say /x64 if it's for all aarchs?
>
> The behavior described in this comment section applies to x64 only (it is the original motivation for introducing this platform printing implementation). This change recognizes that the preexisting Windows x64 solution is essentially platform agnostic (modulo the machine type and registers) and therefore reuses it for Windows AArch64.
Oh, I missed the comment at the bottom, sorry!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27680#discussion_r2446211909
More information about the hotspot-runtime-dev
mailing list