RFR: 8368781: PerfMemory - make issues more transparent [v6]
David Holmes
dholmes at openjdk.org
Tue Oct 21 02:16:04 UTC 2025
On Mon, 20 Oct 2025 14:21:00 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove log_is_enabled
>
> src/hotspot/share/runtime/perfMemory.cpp line 251:
>
>> 249: dest_file, JVM_MAXPATHLEN)) {
>> 250: FREE_C_HEAP_ARRAY(char, dest_file);
>> 251: log_debug(perf)("Invalid performance data file path name specified, "\
>
> Btw is the ` '' `here really needed ? We had it before but most strings over multiple lines do not use it, from what I see ?
No it isn't needed - string literals across new-lines are concatenated. You don't need an explicit line continuation character. Not that it makes any real difference.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27602#discussion_r2446547801
More information about the hotspot-runtime-dev
mailing list