RFR: 8368781: PerfMemory - make issues more transparent [v6]

David Holmes dholmes at openjdk.org
Tue Oct 21 05:38:15 UTC 2025


On Tue, 21 Oct 2025 02:13:16 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> src/hotspot/share/runtime/perfMemory.cpp line 251:
>> 
>>> 249:                                    dest_file, JVM_MAXPATHLEN)) {
>>> 250:       FREE_C_HEAP_ARRAY(char, dest_file);
>>> 251:       log_debug(perf)("Invalid performance data file path name specified, "\
>> 
>> Btw is the ` '' `here really needed ? We had it before but most strings over multiple lines do not use it, from what I see ?
>
> No it isn't needed - string literals across new-lines are concatenated. You don't need an explicit line continuation character. Not that it makes any real difference.

I've suggested reformatting most of these anyway as they don't need to be so short in many cases.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27602#discussion_r2446767012


More information about the hotspot-runtime-dev mailing list