RFR: 8370207: Test sun/misc/SunMiscSignalTest.java crashes after JDK-8369631 [v2]
Coleen Phillimore
coleenp at openjdk.org
Tue Oct 21 20:25:03 UTC 2025
On Mon, 20 Oct 2025 07:38:18 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> I missed that the `UserHandler` can still be used even if `-Xrs` is specified, so we have to check for `!ReduceSignalUsage` as per Kim's initial suggestion in JDK-8369631.
>>
>> Testing
>> - tiers 1-4
>>
>> Thanks
>
> David Holmes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - Un-ProblemList the test
> - Merge branch 'master' into 8370207-sem_notify-crash
> - 8370207: Test sun/misc/SunMiscSignalTest.java crashes after JDK-8369631
Looks good.
src/hotspot/os/posix/signals_posix.cpp line 365:
> 363: AtomicAccess::inc(&pending_signals[sig]);
> 364: sig_semaphore->signal();
> 365: }
So this makes sense because the old code did get there:
https://github.com/openjdk/jdk/commit/680414d0f9ab75d888bcb284cc494124a01a388f#diff-810ea508a8b69c83a17b3f641ac67d9b571324e0a7d66426e4a18580413b3d9aL172-L361
-------------
Marked as reviewed by coleenp (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/27888#pullrequestreview-3362578709
PR Review Comment: https://git.openjdk.org/jdk/pull/27888#discussion_r2449606171
More information about the hotspot-runtime-dev
mailing list