RFR: 8368781: PerfMemory - make issues more transparent [v7]

Matthias Baesken mbaesken at openjdk.org
Wed Oct 22 08:27:42 UTC 2025


On Wed, 22 Oct 2025 07:40:50 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> Matthias Baesken has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Reformatting suggested by David
>>  - unneeded \ removed
>
> src/hotspot/os/windows/perfMemory_windows.cpp line 105:
> 
>> 103:       int nbytes = ::_write(fd, addr, (unsigned int)remaining);
>> 104:       if (nbytes == OS_ERR) {
>> 105:         log_debug(perf)("Could not write Perfdata save file: %s: %s",
> 
> Camel-case?

Probably yes;  it is a bit inconsistent , in perfMemory.cpp we once write 'performance data file path name specified' in some messages.   But mostly we write PerfData .

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27602#discussion_r2450883022


More information about the hotspot-runtime-dev mailing list