RFR: 8369622: GlobalChunkPoolMutex is recursively locked during error handling [v2]

[Coleen Phillimore]

On Wed, 22 Oct 2025 07:51:00 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add assert, fix access modifiers and add Afshin's test.
>
> src/hotspot/share/memory/arena.cpp line 53:
> 
>> 51:     _locked = true;
>> 52:   } else {
>> 53:     precond(ls == LockStrategy::Try);
> 
> Nit: this isn't really a "precond", it is just an assert.

I thought precond was another way of writing assert when there's no meaningful message in the assert, which is why I used it but the name isn't really good here so I'll change it.

> src/hotspot/share/memory/arena.hpp line 44:
> 
>> 42:   enum class LockStrategy { Lock, Try };
>> 43:  private:
>> 44:   bool _locked;
> 
> Nit: if you place this first you can save one of the "public"s.

Done. I agree, I was going to do this - thanks for the push.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27869#discussion_r2451882989
PR Review Comment: https://git.openjdk.org/jdk/pull/27869#discussion_r2451883796