RFR: 8369609: Continuations preempt_epilog is missing a call to invalidate_jvmti_stack [v3]
Serguei Spitsyn
sspitsyn at openjdk.org
Wed Oct 22 20:29:48 UTC 2025
On Wed, 22 Oct 2025 19:00:10 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:
>> Thank you for the comment! Yes, I had in mind but forgot to remove the call to `invalidate_jvmti_stack()` from `jvmti_yield_cleanup()`. I've pushed the update now.
>>
>>> Also I wonder if this call to invalidate_jvmti_stack should just be moved to JvmtiVTMSTransitionDisabler::VTMS_unmount_end instead.
>>
>> Unfortunately, this is not going to work for plain/pure continuations as `mount/unmount` code path does not work for them.
>
> I see. What do you think about adding `invalidate_jvmti_stack` in `jvmti_yield_cleanup` if `!cont.entry()->is_virtual_thread()` is true to address that case?
Good idea! It'd be nice to move the `invalidate_jvmti_stack()` calls out of the continuation code. I'll test it and let you know the results.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27878#discussion_r2453275806
More information about the hotspot-runtime-dev
mailing list