RFR: 8359057: AbstractInterpreter::is_not_reached returns incorrectly with invokedynamic
David Holmes
dholmes at openjdk.org
Thu Oct 23 00:29:14 UTC 2025
On Wed, 22 Oct 2025 21:05:02 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:
>>> Just curious, does this have any observable effect that can surface in a regression test?
>>
>> I took a closer look and the bug is benign since, as the code is shaped now, it doesn't affect inlining decisions in any way. Indy instructions are linked to invokers which are force inlined and it overrides `AbstractInterpreter::is_not_reached() == true` case when it comes to deciding whether to inline through the indy call or not.
>
> Thanks for the review @iwanowww!
> I agree that this change is trivial so one review is sufficient.
As a point-of-order @matias9927 and @iwanowww "simple" does not imply "trivial" from a reviewing perspective.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/27904#issuecomment-3434652370
More information about the hotspot-runtime-dev
mailing list