RFR: 8369622: GlobalChunkPoolMutex is recursively locked during error handling [v2]
David Holmes
dholmes at openjdk.org
Thu Oct 23 01:07:10 UTC 2025
On Wed, 22 Oct 2025 12:14:22 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> src/hotspot/share/memory/arena.cpp line 53:
>>
>>> 51: _locked = true;
>>> 52: } else {
>>> 53: precond(ls == LockStrategy::Try);
>>
>> Nit: this isn't really a "precond", it is just an assert.
>
> I thought precond was another way of writing assert when there's no meaningful message in the assert, which is why I used it but the name isn't really good here so I'll change it.
Thanks. `precond(foo)` is an alternative for checking preconditions (upon method entry) where the assert would typically look like `assert(foo, "precondition")` or `assert(foo, "must be")`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27869#discussion_r2453678316
More information about the hotspot-runtime-dev
mailing list