RFR: 8370064: Test runtime/NMT/CheckForProperDetailStackTrace.java fails on Windows when using stripped pdb files [v3]

[David Holmes]

On Thu, 23 Oct 2025 11:51:38 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> When using stripped and not full pdb files on WIndows, the test CheckForProperDetailStackTrace.java misses source information (but this is not surprise with those much smaller pdb files; so probably we should not rely on having the source info available).
>> error output is :
>> 
>> 
>> java.lang.RuntimeException: Expected source information missing from output
>> at CheckForProperDetailStackTrace.main(CheckForProperDetailStackTrace.java:145)
>> at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
>> at java.base/java.lang.reflect.Method.invoke(Method.java:565)
>> at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:335)
>> at java.base/java.lang.Thread.run(Thread.java:1474)
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Build only whitebox.cpp with new cflag

One style nit.

This still needs build team approval.

Thanks

test/hotspot/jtreg/runtime/NMT/CheckForProperDetailStackTrace.java line 149:

> 147: 
> 148:         if (wb.hasExternalSymbolsStripped()) { expectSourceInformation = false; }
> 149: 

Suggestion:

        if (wb.hasExternalSymbolsStripped()) { 
            expectSourceInformation = false; 
        }

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/27899#pullrequestreview-3374797603
PR Review Comment: https://git.openjdk.org/jdk/pull/27899#discussion_r2459086347