RFR: 8364360: Defining hidden class with no room in constant pool crashes the VM [v2]

Coleen Phillimore coleenp at openjdk.org
Tue Oct 28 11:51:02 UTC 2025


On Tue, 28 Oct 2025 03:45:25 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> In case somebody changes it to int.  There used to be talk about doing this so then the overflow check might have to be different.
>
> Hmm ... then I would prefer simply:
> 
> // Don't change the type of cp_size without updating the overflow
> // check below.
> u2 cp_size = ...;

That's a comment.  The comment isn't executable.  I prefer something that will fail.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27964#discussion_r2469228533


More information about the hotspot-runtime-dev mailing list