RFR: 8370851: Mark hotspot and jdk tests incompatible with test thread factory [v2]

Leonid Mesnik lmesnik at openjdk.org
Thu Oct 30 03:12:46 UTC 2025


On Wed, 29 Oct 2025 06:56:56 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   reverted back one test
>
> test/jdk/com/sun/management/ThreadMXBean/VirtualThreads.java line 28:
> 
>> 26:  * @bug 8284161 8303242
>> 27:  * @summary Test com.sun.management.ThreadMXBean with virtual threads
>> 28:  * @requires test.thread.factory != "Virtual"
> 
> This test allows the "main thread" to be a virtual thread so should pass with JTREG_TEST_THREAD_FACTORY=Virtual. Can you re-check your notes as to why this one should be excluded from JTREG_TEST_THREAD_FACTORY=Virtual runs?
> 
> (all the rest looks okay, excluded via ProblemList-Virtual in the loom repo)

Yes, it is not failing. I thought to exclude it because it is virtual thread specific. But I agree, it is not complaint with overall approach. I am reverting this test change.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28030#discussion_r2476276800


More information about the hotspot-runtime-dev mailing list