RFR: 8366062: [ubsan] add non-zero offset to nullptr in cds/archiveBuilder.cpp [v8]

Afshin Zafari azafari at openjdk.org
Fri Oct 31 11:31:03 UTC 2025


On Fri, 31 Oct 2025 01:19:24 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   suggested change is applied. one error is addressed. one remains still.
>
> src/hotspot/share/cds/archiveBuilder.cpp line 1035:
> 
>> 1033: 
>> 1034: address ArchiveBuilder::offset_to_buffered_address(u4 offset) const {
>> 1035:   // As zero is allowed for _requested_static_archive_bottom, use integer arithmetic to avoid UB pointer arithmetic.
> 
> This comment is no longer needed.

Removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26983#discussion_r2481113722


More information about the hotspot-runtime-dev mailing list