RFR: 8366062: [ubsan] add non-zero offset to nullptr in cds/archiveBuilder.cpp [v9]
Ioi Lam
iklam at openjdk.org
Fri Oct 31 17:19:07 UTC 2025
On Fri, 31 Oct 2025 11:27:38 GMT, Afshin Zafari <azafari at openjdk.org> wrote:
>> It is acceptable that the `SharedBaseAddress` option gets `0` at command line. The corresponding pointer arithmetic with `0` (`nullptr`) in archiveBuilder is UB.
>> Specific casts are used to avoid UBSAN error.
>>
>> Tests:
>> linux-x64-debug: tier1 passed
>
> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>
> reviews applied.
LGTM
Marked as reviewed by iklam (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/26983#pullrequestreview-3405299963
PR Review: https://git.openjdk.org/jdk/pull/26983#pullrequestreview-3405300261
More information about the hotspot-runtime-dev
mailing list