RFR: 8364352: Some tests fail when using a limited number of pregenerated .jsa CDS archives [v2]
David Holmes
dholmes at openjdk.org
Mon Sep 1 04:52:42 UTC 2025
On Fri, 29 Aug 2025 08:53:58 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> Currently the default JVM comes on most platforms with 4 jsa files (for coops and nocoops; with and without compressed object headers), but for some shipments the number of jsa could be reduced (see also Images.gmk) .
>> But not all tests can deal with this.
>> Namely
>>
>> test/hotspot/jtreg/runtime/CompressedOops/CompressedCPUSpecificClassSpaceReservation.java
>> test/hotspot/jtreg/runtime/cds/TestDefaultArchiveLoading.java
>> test/hotspot/jtreg/runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java (custom-cl-zgc)
>>
>> were found to have issues.
>> There is already a requires `vm.cds.default.archive.available` that is used in similar tests and can be used in some of those cases too.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>
> Add vm.cds.nocoops.archive.available
This seems reasonable to me. One nit below.
I will run through our testing. Thanks
test/hotspot/jtreg/runtime/cds/TestDefaultArchiveLoading.java line 98:
> 96:
> 97: private static boolean isArchiveAvailable(char coops, char coh,
> 98: String archiveSuffix) throws Exception {
Suggestion:
private static boolean isArchiveAvailable(char coops, char coh,
String archiveSuffix) throws Exception {
-------------
PR Review: https://git.openjdk.org/jdk/pull/26820#pullrequestreview-3172082364
PR Review Comment: https://git.openjdk.org/jdk/pull/26820#discussion_r2312877745
More information about the hotspot-runtime-dev
mailing list