RFR: 8366498: Wrong InstanceKlass::cast() in ClassFileParser::parse_super_class [v2]
Ioi Lam
iklam at openjdk.org
Mon Sep 1 07:14:28 UTC 2025
> Please review this small change.
>
> It affects debug build only, and I am not even sure if `cp->resolved_klass_at()` is ever called. Since we are very early in class file parsing, it's unlikely that any klass entries have been resolved at this point.
>
> Anyway, for correctness, the `InstanceKlass::cast()` should be done after the check for array class.
Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
Simplify parse_super_klass() -> check_super_class()
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/27026/files
- new: https://git.openjdk.org/jdk/pull/27026/files/d353bfe5..dec4af73
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=27026&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=27026&range=00-01
Stats: 36 lines in 2 files changed: 8 ins; 10 del; 18 mod
Patch: https://git.openjdk.org/jdk/pull/27026.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/27026/head:pull/27026
PR: https://git.openjdk.org/jdk/pull/27026
More information about the hotspot-runtime-dev
mailing list