RFR: 8366498: Simplify ClassFileParser::parse_super_class [v2]
David Holmes
dholmes at openjdk.org
Mon Sep 1 07:32:43 UTC 2025
On Mon, 1 Sep 2025 07:14:28 GMT, Ioi Lam <iklam at openjdk.org> wrote:
>> The if `cp->resolved_klass_at()` is never true called because we are very early in class file parsing, so no klass CP entries have been resolved at this point.
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>
> Simplify parse_super_klass() -> check_super_class()
src/hotspot/share/classfile/classFileParser.cpp line 3824:
> 3822:
> 3823: // Ioi note: remove this in final commit.
> 3824: assert(!cp->tag_at(super_class_index).is_klass(), "should not have been resolved");
I suggest not including this in the PR then adding it locally for testing purposes - else you guarantee the need for a re-review.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27026#discussion_r2313118181
More information about the hotspot-runtime-dev
mailing list