RFR: 8366498: Simplify ClassFileParser::parse_super_class [v2]

[David Holmes]

On Mon, 1 Sep 2025 07:14:28 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> The if `cp->resolved_klass_at()` is never true called because we are very early in class file parsing, so no klass CP entries have been resolved at this point.
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Simplify parse_super_klass() -> check_super_class()

Amazing how one incorrect cast led to that cascade of code changes. :)

Overall seems valid. A couple of nits.

Thanks

src/hotspot/share/classfile/classFileParser.cpp line 5798:

> 5796:   } else {
> 5797:     assert(_class_name == vmSymbols::java_lang_Object(), "already checked");
> 5798:     _super_klass = nullptr;

This seems unnecessary. We have already check the name and `_super_klass` is initialized to null.

-------------

PR Review: https://git.openjdk.org/jdk/pull/27026#pullrequestreview-3172463258
PR Review Comment: https://git.openjdk.org/jdk/pull/27026#discussion_r2313139011