RFR: 8364816: GetLastError() in os_windows.cpp should not store value to errno [v7]

[David Holmes]

On Mon, 1 Sep 2025 09:51:30 GMT, Anton Artemov <duke at openjdk.org> wrote:

>> Hi, please consider the following changes:
>> 
>> In `os_windows.cpp` in a few places results returned by `GetLastError()` are stored to `errno`. However, `errno` has no relation to `GetLastError()`, and their ranges are not the same.
>> 
>> Results of `GetLastError()` should be stored into variables of type `DWORD`.
>> 
>> The removed section in `src/hotspot/share/cds/aotClassLocation.cpp` was relying on values returned by `GetLastError()` and stored to `errno` in `os::stat()`. Though the logic was correct, these values should not be stored to `errno`. The functionality is preserved by storing a **valid** value `ENOENT` to `errno` in `os::stat()`. 
>> 
>> Tested in tiers 1 - 3.
>
> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update src/hotspot/os/windows/os_windows.cpp
>   
>   8364816: Added _set_errno(0) to avoid reading old values.
>   
>   Co-authored-by: Joel Sikström <joel.sikstrom at oracle.com>

Changes requested by dholmes (Reviewer).

src/hotspot/os/windows/os_windows.cpp line 4823:

> 4821:       errno = ENOENT;
> 4822:     } else {
> 4823:       _set_errno(0);

I don't object to setting it to zero explicitly but we do not need to use `_set_errno` to do it!
Suggestion:

      errno = 0;

-------------

PR Review: https://git.openjdk.org/jdk/pull/26901#pullrequestreview-3174505140
PR Review Comment: https://git.openjdk.org/jdk/pull/26901#discussion_r2314587851