RFR: 8364816: GetLastError() in os_windows.cpp should not store value to errno [v8]
Anton Artemov
duke at openjdk.org
Tue Sep 2 07:31:28 UTC 2025
> Hi, please consider the following changes:
>
> In `os_windows.cpp` in a few places results returned by `GetLastError()` are stored to `errno`. However, `errno` has no relation to `GetLastError()`, and their ranges are not the same.
>
> Results of `GetLastError()` should be stored into variables of type `DWORD`.
>
> The removed section in `src/hotspot/share/cds/aotClassLocation.cpp` was relying on values returned by `GetLastError()` and stored to `errno` in `os::stat()`. Though the logic was correct, these values should not be stored to `errno`. The functionality is preserved by storing a **valid** value `ENOENT` to `errno` in `os::stat()`.
>
> Tested in tiers 1 - 3.
Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
Update src/hotspot/os/windows/os_windows.cpp
8364816: Changed the way errno is set to zero.
Co-authored-by: David Holmes <62092539+dholmes-ora at users.noreply.github.com>
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/26901/files
- new: https://git.openjdk.org/jdk/pull/26901/files/2789bb92..9d69ac3c
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=26901&range=07
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=26901&range=06-07
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/26901.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/26901/head:pull/26901
PR: https://git.openjdk.org/jdk/pull/26901
More information about the hotspot-runtime-dev
mailing list