RFR: 8366498: Simplify ClassFileParser::parse_super_class [v4]

David Holmes dholmes at openjdk.org
Thu Sep 4 07:23:45 UTC 2025


On Thu, 4 Sep 2025 06:07:29 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> The if `cp->resolved_klass_at()` is never true called because we are very early in class file parsing, so no klass CP entries have been resolved at this point.
>
> Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Merge branch 'master' into 8366498-wrong-instance-klass-cast-in-parse-super-class
>  - @coleenp review - updated asserts
>  - removed test-only assert
>  - Simplify parse_super_klass() -> check_super_class()
>  - 8366498: Wrong InstanceKlass::cast() in ClassFileParser::parse_super_class

Looks good. Thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/27026#pullrequestreview-3183806985


More information about the hotspot-runtime-dev mailing list