RFR: 8366908: Use a different class for testing JDK-8351654 [v2]

Chen Liang liach at openjdk.org
Sat Sep 6 17:10:10 UTC 2025


On Sat, 6 Sep 2025 16:07:07 GMT, ExE Boss <duke at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove unreachable line.
>
> test/hotspot/jtreg/runtime/verifier/CFLH/TestVerify.java line 93:
> 
>> 91:                     builder.with(element);
>> 92:                 });
>> 93:                 var classTransform = ClassTransform.transformingMethods(mm -> mm.methodName().stringValue().equals("parse"), methodTransform);
> 
> This can use [`Utf8Entry::equalsString`] to avoid unnecessarily inflating all method names:
> Suggestion:
> 
>                 var classTransform = ClassTransform.transformingMethods(mm -> mm.methodName().equalsString("parse"), methodTransform);
> 
> 
> [`Utf8Entry::equalsString`]: https://docs.oracle.com/en/java/javase/24/docs/api/java.base/java/lang/classfile/constantpool/Utf8Entry.html#equalsString%28java.lang.String%29

True, but I don't think we need to be this careful for tests.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27116#discussion_r2327950682


More information about the hotspot-runtime-dev mailing list