RFR: 8366908: Use a different class for testing JDK-8351654 [v2]
Coleen Phillimore
coleenp at openjdk.org
Sun Sep 7 18:12:11 UTC 2025
On Sat, 6 Sep 2025 17:07:34 GMT, Chen Liang <liach at openjdk.org> wrote:
>> test/hotspot/jtreg/runtime/verifier/CFLH/TestVerify.java line 93:
>>
>>> 91: builder.with(element);
>>> 92: });
>>> 93: var classTransform = ClassTransform.transformingMethods(mm -> mm.methodName().stringValue().equals("parse"), methodTransform);
>>
>> This can use [`Utf8Entry::equalsString`] to avoid unnecessarily inflating all method names:
>> Suggestion:
>>
>> var classTransform = ClassTransform.transformingMethods(mm -> mm.methodName().equalsString("parse"), methodTransform);
>>
>>
>> [`Utf8Entry::equalsString`]: https://docs.oracle.com/en/java/javase/24/docs/api/java.base/java/lang/classfile/constantpool/Utf8Entry.html#equalsString%28java.lang.String%29
>
> True, but I don't think we need to be this careful for tests.
True, but why not?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27116#discussion_r2328788477
More information about the hotspot-runtime-dev
mailing list