RFR: 8349288: runtime/os/windows/TestAvailableProcessors.java fails on localized Windows platform [v9]

Alan Bateman alanb at openjdk.org
Tue Sep 9 12:47:29 UTC 2025


On Wed, 25 Jun 2025 08:18:19 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> To resolve runtime/os/windows/TestAvailableProcessors.java failure, I made "systeminfo.exe" executed with "chcp 437". This ensures that the English message "OS Version: " is output on localized windows platforms.
>> I added the path C:\Windows\System32 to make chcp command recognized on the GHA Windows test machine. Without this addition, GHA will fail.
>> After this fix, I verified that the test passed.
>> 
>> https://github.com/openjdk/jdk/pull/22142
>> I refer to this fix.
>> tools/jpackage/windows/Win8301247Test.java does not run in GHA, so the problems with recognition of chcp command did not occur before.
>> 
>> Thanks.
>
> Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8349288: runtime/os/windows/TestAvailableProcessors.java fails on localized Windows platform

Looks okay to me, thanks for moving away from the hardcoded root.

test/hotspot/jtreg/runtime/os/windows/TestAvailableProcessors.java line 37:

> 35:  */
> 36: 
> 37: import java.io.File;

I assume this is a left-over from early iterations.

-------------

Marked as reviewed by alanb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23536#pullrequestreview-3201363507
PR Review Comment: https://git.openjdk.org/jdk/pull/23536#discussion_r2333428827


More information about the hotspot-runtime-dev mailing list