RFR: 8367268: Remove unused os::numa_topology_changed()
David Holmes
dholmes at openjdk.org
Wed Sep 10 07:17:19 UTC 2025
On Tue, 9 Sep 2025 16:39:17 GMT, Joel Sikström <jsikstro at openjdk.org> wrote:
> Hello,
>
> The method os::numa_topology_changed() returns false on all platforms with no callers. It makes sense to remove it as the JVM does not support changing the NUMA topology during runtime, or in other words, hotswapping CPUs. There are a lot of places that break if the NUMA topology would change during runtime.
>
> The last implementation of os::numa_topology_changed() that did something other than just returning false was removed in [JDK-8244224](https://bugs.openjdk.org/browse/JDK-8244224) with the removal of the Solaris and SPARC ports.
>
> I do not see an issue with building on AIX, but would appreciate any feedback on this from AIX maintainers.
>
> Testing:
> * Running through tier1 on Oracle supported platforms
Nice cleanup. Thanks
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/27176#pullrequestreview-3204754695
More information about the hotspot-runtime-dev
mailing list