RFR: 8367371: Remove @requires vm.opt.UseLargePages from InternSharedString.java test [v2]
Joel Sikström
jsikstro at openjdk.org
Thu Sep 11 14:00:31 UTC 2025
On Thu, 11 Sep 2025 13:56:51 GMT, Paul Hübner <phubner at openjdk.org> wrote:
>> Hi all,
>>
>> This PR removes the requirement to not use large pages for the given CDS test. CDS now supports large pages.
>>
>> Tested `InternSharedString.java` on Linux x64 and Linux AArch64 with `-XX:+UseLargePages`. 5x 100 iterations.
>
> Paul Hübner has updated the pull request incrementally with one additional commit since the last revision:
>
> Update test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/InternSharedString.java
>
> Co-authored-by: Joel Sikström <joel.sikstrom at oracle.com>
Changes requested by jsikstro (Reviewer).
test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/InternSharedString.java line 30:
> 28: * @requires vm.cds.write.archived.java.heap
> 29: * @requires vm.gc == null
> 30: * @comment CDS archive heap mapping is not supported with large pages
We should remove the comment as well.
Suggestion:
-------------
PR Review: https://git.openjdk.org/jdk/pull/27218#pullrequestreview-3211750482
PR Review Comment: https://git.openjdk.org/jdk/pull/27218#discussion_r2340988758
More information about the hotspot-runtime-dev
mailing list