RFR: 8366658: Add missing locks when accessing the VirtualMemoryTracker instance in tests and MemMapPrinter
Paul Hübner
phubner at openjdk.org
Fri Sep 12 08:14:29 UTC 2025
On Thu, 4 Sep 2025 07:42:31 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
>> Hi,
>>
>> This PR adds the missing locks for the tests and MemMapPrinter, also fixes a small bug in `walk_virtual_memory`. See inline review comments.
>>
>> Passes tier1.
>
> src/hotspot/share/nmt/virtualMemoryTracker.cpp line 221:
>
>> 219: });
>> 220: return ret;
>> 221: }
>
> A VirtualMemoryWalker returned true or false depending on whether or not its operation succeeded, and we are meant to pass that along as the return value of walk_virtual_memory. That was missing, now fixed.
Nice catch!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27038#discussion_r2343365995
More information about the hotspot-runtime-dev
mailing list