RFR: 8366658: Add missing locks when accessing the VirtualMemoryTracker instance in tests and MemMapPrinter [v2]

Paul Hübner phubner at openjdk.org
Fri Sep 12 09:11:22 UTC 2025


On Fri, 12 Sep 2025 09:05:50 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> src/hotspot/share/nmt/memTracker.hpp line 183:
>> 
>>> 181:   }
>>> 182: 
>>> 183:   static inline MemoryFileTracker::MemoryFile* register_file(const char* descriptive_name) {
>> 
>> Same here. I wonder why we have the inline header when it only contains `MemTracker::check_exceeds_limit`...
>
> Hmm, so do I. I've never used the inline header myself. I think moving stuff over to the inline header is something we should think about in a separate PR.

I'm okay with that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27038#discussion_r2343539573


More information about the hotspot-runtime-dev mailing list