RFR: 8366658: Add missing locks when accessing the VirtualMemoryTracker instance in tests and MemMapPrinter [v2]
Johan Sjölen
jsjolen at openjdk.org
Fri Sep 12 09:11:24 UTC 2025
On Fri, 12 Sep 2025 02:19:24 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update src/hotspot/share/nmt/virtualMemoryTracker.hpp
>>
>> Co-authored-by: David Holmes <62092539+dholmes-ora at users.noreply.github.com>
>
> src/hotspot/share/nmt/virtualMemoryTracker.hpp line 347:
>
>> 345:
>> 346: class VirtualMemoryWalker : public StackObj {
>> 347: public:
>
> Suggestion:
>
> public:
>
> The access modifier should be indented by 1
You're right, that is the style of this file.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27038#discussion_r2343542580
More information about the hotspot-runtime-dev
mailing list