RFR: 8366658: Add missing locks when accessing the VirtualMemoryTracker instance in tests and MemMapPrinter [v3]

Johan Sjölen jsjolen at openjdk.org
Fri Sep 12 09:16:49 UTC 2025


On Fri, 12 Sep 2025 02:20:43 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'origin/missing-locks' into missing-locks
>>  - Merge lock blocks
>
> test/hotspot/gtest/runtime/test_committed_virtualmemory.cpp line 50:
> 
>> 48:       MemTracker::NmtVirtualMemoryLocker nvml;
>> 49:       VirtualMemoryTracker::Instance::snapshot_thread_stacks();
>> 50:     }
> 
> Why two separate locking blocks?

No reason, let's merge them.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27038#discussion_r2343550127


More information about the hotspot-runtime-dev mailing list