RFR: 8367486: Change prefix for platform-dependent AtomicAccess files [v3]
Kim Barrett
kbarrett at openjdk.org
Mon Sep 15 04:22:11 UTC 2025
On Fri, 12 Sep 2025 08:08:48 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
>> JDK-8367014 renamed the class Atomic to AtomicAccess and renamed atomic.hpp to atomicAccess.hpp. I propose that we also rename the platform-dependent headers that implement the AtomicAccess support to be named atomicAccess_<os>_<arch>.hpp.
>>
>> Note that I left atomic_aarch64.hpp and atomic_linux_aarch64.S intact since they clear, external usages outside of the AtomicAccess class.
>>
>> I will verify that this still builds on the platform that I can easily build.
>
> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix zero
Changes requested by kbarrett (Reviewer).
src/hotspot/os_cpu/linux_zero/os_linux_zero.cpp line 27:
> 25:
> 26: #include "asm/assembler.inline.hpp"
> 27: #include "atomicAccess_linux_zero.hpp"
The platform-specific atomic[Access] headers were never really intended for direct inclusion.
I think it's being included here to get atomic_copy64. But there is code in this file that I think
*should* be using `AtomicAccess`. But that's a pre-existing issue that doesn't need to be dealt
with in this PR. But I'd prefer this included `atomicAccess.hpp`.
src/hotspot/os_cpu/linux_zero/os_linux_zero.cpp line 27:
> 25:
> 26: #include "asm/assembler.inline.hpp"
> 27: #include "atomicAccess_linux_zero.hpp"
It looks like `os_bsd_zero.cpp` has the same issue, but doesn't seem to be touched in this PR?
-------------
PR Review: https://git.openjdk.org/jdk/pull/27245#pullrequestreview-3222859554
PR Review Comment: https://git.openjdk.org/jdk/pull/27245#discussion_r2347840944
PR Review Comment: https://git.openjdk.org/jdk/pull/27245#discussion_r2347842074
More information about the hotspot-runtime-dev
mailing list