RFR: 8367486: Change prefix for platform-dependent AtomicAccess files [v3]
Kim Barrett
kbarrett at openjdk.org
Mon Sep 15 04:30:11 UTC 2025
On Mon, 15 Sep 2025 04:16:15 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix zero
>
> src/hotspot/os_cpu/linux_zero/os_linux_zero.cpp line 27:
>
>> 25:
>> 26: #include "asm/assembler.inline.hpp"
>> 27: #include "atomicAccess_linux_zero.hpp"
>
> The platform-specific atomic[Access] headers were never really intended for direct inclusion.
> I think it's being included here to get atomic_copy64. But there is code in this file that I think
> *should* be using `AtomicAccess`. But that's a pre-existing issue that doesn't need to be dealt
> with in this PR. But I'd prefer this included `atomicAccess.hpp`.
Or maybe the definition of `atomic_copy64` for linux-zero should be moved to `os_linux_zero.cpp`, which
I think would be consistent with all of the other definitions/uses of that function.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27245#discussion_r2347848918
More information about the hotspot-runtime-dev
mailing list