RFR: 8367486: Change prefix for platform-dependent AtomicAccess files [v3]

Stefan Karlsson stefank at openjdk.org
Mon Sep 15 06:19:25 UTC 2025


On Mon, 15 Sep 2025 04:27:24 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> src/hotspot/os_cpu/linux_zero/os_linux_zero.cpp line 27:
>> 
>>> 25: 
>>> 26: #include "asm/assembler.inline.hpp"
>>> 27: #include "atomicAccess_linux_zero.hpp"
>> 
>> The platform-specific atomic[Access] headers were never really intended for direct inclusion.
>> I think it's being included here to get atomic_copy64. But there is code in this file that I think
>> *should* be using `AtomicAccess`. But that's a pre-existing issue that doesn't need to be dealt
>> with in this PR. But I'd prefer this included `atomicAccess.hpp`.
>
> Or maybe the definition of `atomic_copy64` for linux-zero should be moved to `os_linux_zero.cpp`, which
> I think would be consistent with all of the other definitions/uses of that function.

I've updated the file to use atomicAccess.hpp, but I'll let someone else make the move of the function if that is deemed to be the right thing to do.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27245#discussion_r2347968800


More information about the hotspot-runtime-dev mailing list