RFR: 8367981: Refine CompactHashtable comments [v2]

Hamlin Li mli at openjdk.org
Thu Sep 18 12:48:04 UTC 2025


On Thu, 18 Sep 2025 11:21:23 GMT, Francesco Andreuzzi <fandreuzzi at openjdk.org> wrote:

>> src/hotspot/share/classfile/compactHashtable.cpp line 195:
>> 
>>> 193: size_t SimpleCompactHashtable::calculate_header_size() {
>>> 194:   // We have 5 fields. Each takes up sizeof(intptr_t). See WriteClosure::do_u4
>>> 195:   constexpr size_t bytes = sizeof(intptr_t) * 5;
>> 
>> The whole method could perhaps become a `constexpr`
>
> And you could have the assertion below just after the class is defined

This can just be removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27360#discussion_r2359064830


More information about the hotspot-runtime-dev mailing list