RFR: 8367485: os::physical_memory is broken in 32-bit JVMs when running on 64-bit OSes [v3]

Anton Artemov duke at openjdk.org
Thu Sep 18 14:02:02 UTC 2025


On Thu, 18 Sep 2025 13:53:03 GMT, Joel Sikström <jsikstro at openjdk.org> wrote:

>> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8367485: Addressed reviewer's comments.
>
> src/hotspot/share/runtime/os.cpp line 1944:
> 
>> 1942:   //     We allow some part (1/8?) of the memory to be "missing",
>> 1943:   //     based on the sizes of DIMMs, and maybe graphics cards.
>> 1944:   const uint64_t missing_memory   = 256UL * M;
> 
> There was some alignment going on here. Either we keep it or we might as well remove the spacing.

Addressed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27335#discussion_r2359460848


More information about the hotspot-runtime-dev mailing list