RFR: 8367485: os::physical_memory is broken in 32-bit JVMs when running on 64-bit OSes [v4]
    Anton Artemov 
    duke at openjdk.org
       
    Thu Sep 18 14:35:53 UTC 2025
    
    
  
On Thu, 18 Sep 2025 14:15:10 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
>> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8367485: Addressed reviewer's comments
>
> src/hotspot/os/windows/os_windows.cpp line 3967:
> 
>> 3965: // Processor level is not available on non-NT systems, use vm_version instead
>> 3966: int    os::win32::_processor_level           = 0;
>> 3967: uint64_t os::win32::_physical_memory         = 0;
> 
> I suggest that you change the three variables to:
> 
> int      os::win32::_processor_type          = 0;
> // Processor level is not available on non-NT systems, use vm_version instead
> int      os::win32::_processor_level         = 0;
> uint64_t os::win32::_physical_memory         = 0;
> 
> bool     os::win32::_is_windows_server       = false;
> 
> The proposed patch messes up the pre-existing alignment.
Thanks, addressed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27335#discussion_r2359609918
    
    
More information about the hotspot-runtime-dev
mailing list