RFR: 8367981: Update CompactHashtable comments [v2]
Ioi Lam
iklam at openjdk.org
Tue Sep 23 21:34:27 UTC 2025
On Tue, 23 Sep 2025 18:59:10 GMT, Hamlin Li <mli at openjdk.org> wrote:
>>> All parameters of offset should be changed to encoded_value.
>>
>> I guess you mean change from `value` to encoded_value in `CompactHashtable`?
>> I did not touch the parameter name `offset` in read_value_from_compact_hashtable (which is used in OffsetCompactHashtable), as I think it means `offset` intentionally.
>> But please correct me if I'm understanding wrongly.
>
> Modify from `offset`/`value` to `encoded_value` in CompactHashtable template parameters.
Yes, that's what I wanted, rename the field/params in CompactHashtable to `encoded_value`. We can leave `offset` in the other places.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27360#discussion_r2373504011
More information about the hotspot-runtime-dev
mailing list