RFR: 8367981: Update CompactHashtable comments [v4]
Hamlin Li
mli at openjdk.org
Wed Sep 24 08:34:37 UTC 2025
On Tue, 23 Sep 2025 21:37:16 GMT, Ioi Lam <iklam at openjdk.org> wrote:
>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>>
>> rename
>
> src/hotspot/share/classfile/compactHashtable.hpp line 98:
>
>> 96:
>> 97: u4 value() {
>> 98: return _encoded_value;
>
> The accessor should also be renamed to `encoded_value()`. There are also comments like `(hash, value)` that should also be renamed,
make sense, updated.
> src/hotspot/share/classfile/compactHashtable.hpp line 197:
>
>> 195: // - The 0-th bucket is a REGULAR_BUCKET_TYPE with two entries
>> 196: // - The 1-st bucket is a VALUE_ONLY_BUCKET_TYPE with one entry.
>> 197: // - The 2-th bucket is a REGULAR_BUCKET_TYPE with zeo entries.
>
> Sorry I had some typos in my original suggestion. Here's the fixed version. I think this will be easier to read:
>
> Suggestion:
>
> // - Bucket #0 is a REGULAR_BUCKET_TYPE with two entries
> // - Bucket #1 is a VALUE_ONLY_BUCKET_TYPE with one entry.
> // - Bucket #2 is a REGULAR_BUCKET_TYPE with zero entries.
Thanks, updated.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27360#discussion_r2374960090
PR Review Comment: https://git.openjdk.org/jdk/pull/27360#discussion_r2374959506
More information about the hotspot-runtime-dev
mailing list